Implement grow/shrink/wrap/scroll policy in build_staff_layout - #5
Merged
Merged
Conversation
Measures now pack into rows via greedy fill, growing to fill available width and shrinking toward a legibility floor (48em) before wrapping into a new row; a single measure too wide even at the floor is left to overflow into horizontal scroll. Growth only stretches note spacing (glyph size unaffected, preserving prior single-system behavior); shrinking scales glyph size and width together, since that's the only direction that actually risks illegibility. Adds StaffOpts::rescaled/GlyphMetrics::scaled so the renderer's font and metrics track the scale build_staff_layout used. Widens measure_panel's ScrollArea to both() and makes hit_test_staff row-aware. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
em) and width together via newStaffOpts::rescaled/GlyphMetrics::scaled, since shrinking width alone would just make same-size glyphs collide.measure_panel.rs:ScrollAreawidened toboth();hit_test_staffis now row-aware (Pos2instead off32x-only).48em(LEGIBILITY_FLOOR_EMincrates/layout/src/staff_layout.rs) — see linked wayfinder map/tickets #1, #2, #3, #4 for the full decision trail.Test plan
cargo test --workspace(excludinggrooph-measure, which fails to compile on this toolchain for an unrelated, pre-existing reason confirmed present onmainbefore this change)cargo fmt --checkcrates/layout/src/staff_layout.rs: fits-one-row regression, multi-row wrap, single-measure-too-wide scroll fallback, row-aware hit-testing🤖 Generated with Claude Code