Skip to content

Delete particles individually when resting in reveal mode - #525

Merged
tailuge merged 1 commit into
masterfrom
reveal-particles-delete-resting-10810609898617373794
Sep 23, 2026
Merged

tailuge merged 1 commit into
masterfrom
reveal-particles-delete-resting-10810609898617373794

Conversation

@tailuge

@tailuge tailuge commented Sep 23, 2026

Copy link
Copy Markdown
Owner

Deletes particle instances individually as they reach resting position at end of animation when reveal gametype is set.


PR created automatically by Jules for task 10810609898617373794 started by @tailuge

Co-authored-by: tailuge <5666965+tailuge@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.63%. Comparing base (a4c545d) to head (c61e4cc).

Files with missing lines Patch % Lines
src/view/particle-system.ts 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   71.64%   71.63%   -0.02%     
==========================================
  Files         147      147              
  Lines       11643    11651       +8     
  Branches     2266     2271       +5     
==========================================
+ Hits         8342     8346       +4     
- Misses       3301     3305       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tailuge
tailuge merged commit b4fdb2a into master Sep 23, 2026
7 of 9 checks passed
@tailuge
tailuge deleted the reveal-particles-delete-resting-10810609898617373794 branch September 23, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant