Use Manta Ray loader and collision member interfaces - #2751
Conversation
✅ PR validation — PassedCommitted merge introduces no reconstruction or attribution regression. Full merge validation
Byte-verified means the range carries Per-file link-check detailAll 2 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.
The private worker commits a test merge, builds the stock ROM profile, compares every executable module, measures matched and source-built code, checks contributor lineage, and verifies affected relocations. The mod profile is opt-in and is not part of this merge gate. |
…e/review-queue-0918
…e/review-queue-0918
…e/review-queue-0918
Manta Ray declared
Animation::LoadFilelocally as returningvoid, conflicting with the sharedchar*contract, and called several existing methods through manually spelled mangled names. Use the shared loader declarations,mModelAnim.SetFile, inheritedUpdatePosWithOnlySpeed, and the collision object'sClear/Updatemethods. This removes six unnecessary bridge declarations without changing headers or layouts.Follow-up to #2729, which landed before this repair. Both methods pass fresh relocation-aware checks under pinned
2004/b56; the complete module build is 106/106 exact with 11,206 reproducing functions and zero mismatches. Port references pass (423 checked), and attribution shows zero changed or lost credit. The full build reused cached objects; the two target methods were compiled and link-checked separately. Existing incomplete ROM-data coverage is unchanged and is not claimed as complete.Reconstruction remains partial: the callback shadow types, raw field/vector views, and collision-initialization bridge are tracked in #2750. This patch claims no compiler barrier for them. The committed handoff retains the original review findings. Queue task:
manta-contract-repair-0918.Independent review accepts exact head
e741d4f6e16696ea9f5ec26625eaeaf42b8f4ee2against base6a8b012074dcb805974767cb4ac18adeb72f11bbas partial reconstruction. Fresh compilation verifies 852 bytes and 38 relocations; the composed build remains 106/106 exact. Queue taskmanta-composition6-review-0918retains all six findings. Required private PR validation is pending; this is not a merge acceptance.