Support EmmyLua analyzer and brong EmmyLua annotations - #551
Draft
ligurio wants to merge 9 commits into
Draft
Conversation
The patch introduces an initial configuration file .emmyrc for
emmylua_check, it is a modern static analuzer for Lua.
The configuration file has the same excluded directories as in
.luacheckrc and config disables a number of rules. Most of them
will be enabled back in the following commits except the following
rules:
- "unresolved-require" (7 warnings) is disabled because most modules
are Tarantool builtins: `json`, `log`, `uuid`; no source code is
included in the project.
- "need-check-nil" (22 warnings) is disabled because these
warnings are not critical and I don't want to add extra checks
to the code.
- "redefined-local" is disabled because it was disabled for
luacheck in the commit 49fa005dab08a1b206771e89e5231f779cccf914
("test: add linting stage").
The patch enables rule "access-invisible" and fixes a single warning produced by this rule. The warning is actually is a false positive in the analyzer's bundled std library. `math.randomseed(0)` is valid in LuaJIT (5.1 semantics), but the analyzer's built-in `std/math.lua` tags it with PUC Rio Lua versions only, not LuaJIT.
ligurio
marked this pull request as draft
August 11, 2026 15:19
49 tasks
ligurio
force-pushed
the
ligurio/gh-xxxx-emmylua-annotations
branch
from
August 11, 2026 15:22
2e849b6 to
a56f711
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-emmylua-annotations
branch
from
August 11, 2026 15:25
a56f711 to
00484bf
Compare
The patch adds EmmyLua annotations to the public-API files and minimal descriptions (based on the API reference) for all public functions. Needed for tarantool/tarantool#13020
ligurio
force-pushed
the
ligurio/gh-xxxx-emmylua-annotations
branch
from
August 11, 2026 15:26
00484bf to
8cefd0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.