Return SDK Task objects from list_tasks - #61
Open
snopoke wants to merge 6 commits into
Open
Conversation
Wrap the generated PaginatedTaskList so the public API stops leaking taskbadger.internal models. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
snopoke
marked this pull request as ready for review
August 6, 2026 15:50
These are created in task_prerun rather than at publish time, where the explicit parent was being ignored. Also disconnect all signal handlers in the system integration test, not just task_prerun — the rest stayed connected from the stale module and fired twice for the remainder of the session. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
snopoke
force-pushed
the
sk/list-tasks-wrapper
branch
from
August 6, 2026 18:33
6799d9a to
bec0786
Compare
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_taskshanded back the raw generatedPaginatedTaskList, so.resultswereinternal.models.Task— noupdate(),safe_update(), or any of the SDK surface. Callers had to know aboutinternal/to do anything useful with a listed task. It now returns aTaskListwrapping SDKTasks, iterable directly.Two compatibility notes for the reviewer, both deliberate:
TaskListdefines__len__, so an empty page is now falsy wherePaginatedTaskListwas always truthy.if taskbadger.list_tasks(...)changes meaning.additional_properties(page["unknown_key"],"k" in page) doesn't pass through — special methods bypass__getattr__.page.additional_propertiesstill works. Nothing in-repo used it; flagging in case it's considered public.Also here, unrelated to the above:
taskbadger_parentand always nested under the enclosing task. They now honour it, including an explicitNonemeaning "make this a root task", matching publish-time behavior.invoke tag-releasenow runsuv lockbefore committing — the lockfile pins the project's own version, so it was going stale on every release.