Conversation
BaerLKR
reviewed
Apr 20, 2026
BaerLKR
left a comment
BaerLKR
left a comment
Contributor
There was a problem hiding this comment.
seems fine to me
majority is refactoring anyways
BaerLKR
reviewed
Apr 24, 2026
BaerLKR
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made
I added procedures and split
fntofuncandproc. Additionally, the TokenTowas introduced to represent the left arrow (->), which is now used for specifying return types. Besides that, this pr contains two minor fixes. The first one is a small bug fix that prevents ignoring every second input file inside the cli. The other is a feature for all Visitor traits to use associated types.Related issues
This pr implements some features of #16. It is just the first one of many. I decided to split the changes into multiple smaller bug fixes because I think that this way it will be easier to review and understand what was changed.
Checklist
cargo test)cargo fmt)