fix(sql-editor): FoxScript review fixes (tokens, Out[n], CRLF, Play) - #126
Merged
Conversation
- Encode Monaco semantic tokens as 0-based line/column deltas - Build virtual docs from parent buffer slices (CRLF-safe projection) - Recognize fence markers with trailing CR; align Out [n] with In [n] - Disable SQL cell Play without a Destination; suppress SQL suggests in fences Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
huyplb
marked this pull request as ready for review
July 29, 2026 00:34
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_cae12afd-6087-4968-9fb4-9e211e63de96) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up after Bugbot + Security review of the FoxScript / notebook SQL Editor work (already on
mainvia #124/#125).Bugbot fixes
\rOut [n]aligns withIn [n]viaranStatementIndicesprojectToVirtualDoc)Security
parseSetDirectives/ existing splitterTest plan
tsc --noEmitfor apps/webOut [3]