Remove 'Outcome' types, moving fields to parent protos - #849
Merged
Conversation
VegetarianOrc
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
There are two changes in this PR, both breaking changes. (But since the feature is under development, this won't impact users in any way.)
(1) Remove the
callbackpb.CallbackOutcomeproto, and instead move thesuccess/failurefields directly intocallbackpb.CallbackInfo. Do the same forOnCompleteRequest, removing theOnCompleteRequest.Outcomemessage.It's extremely unlikely we would ever add a new variant for the callback's result, and having the extra layer of indirection made the SDK and server-side code cumbersome.
(2) Have
OnCompleteRequest.resultvariantsuccessbe acommonpb.Payloadinstead of acommonpb.Payloads.The Temporal API makes it look as if a Workflow can return multiple values. (i.e. a
commonpb.Payloads.) But in reality, the SDK only ever deals with a single value (commonpb.Payload).And the extra layer of indirection via
commonpb.Payloadsalso made the SDK and server-side code more cumbersome.Breaking changes
Yes. But this is still a WIP feature branch. The only person being broken is, alas, @chrsmith .