Render links on activity describe - #1131
Conversation
ce0c55d to
1ca8e25
Compare
|
Please add the examples to the PR description. helps with the review. |
|
@chaptersix This PR doesn't add any new commands so I am not sure what example would be helpful |
There was a problem hiding this comment.
Pull request overview
This PR adds consistent rendering of Nexus-style link URLs in CLI “describe” outputs, extending link rendering to activity describe and nexus operation describe, and refactoring callback rendering into shared helpers.
Changes:
- Add shared helpers to convert/print Temporal common links as Nexus URL strings and reuse them across commands.
- Refactor workflow/activity callback rendering into a single shared
printCallbacksimplementation (including callback URL, trigger, links, state, etc.). - Add unit tests covering link conversion and link/callback rendering; update a batch JSON expectation for the operation type string.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/temporalcli/commands.workflow_view.go | Switch workflow describe callback rendering to shared printCallbacks. |
| internal/temporalcli/commands.nexus_operation.go | Print a Links section for Nexus operation descriptions. |
| internal/temporalcli/commands.link_test.go | Add unit tests for link conversion and for activity/nexus operation link rendering. |
| internal/temporalcli/commands.go | Add nexusLinkStrings, printLinks, and generic callback normalization/printing helpers. |
| internal/temporalcli/commands.batch_test.go | Update expected JSON operation type string. |
| internal/temporalcli/commands.activity.go | Render activity Links section and reuse shared callback printing. |
| go.mod | Bump go.temporal.io/api and several other dependencies (direct/indirect). |
| go.sum | Update module checksums corresponding to dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| activitypb "go.temporal.io/api/activity/v1" | ||
| "go.temporal.io/api/common/v1" | ||
| commonpb "go.temporal.io/api/common/v1" | ||
| "go.temporal.io/api/enums/v1" |
There was a problem hiding this comment.
This isn't my change, it should be fixed but I think it should be in a separate PR since this will touch a lot of files
mostly looking for a before and after. keep in mind I'm not up to speed on everything nexus or activities. |
| s.NoError(json.Unmarshal(res.Stdout.Bytes(), &jsonOut)) | ||
| s.Equal(jobId, jsonOut["jobId"]) | ||
| s.Equal("BATCH_OPERATION_TYPE_TERMINATE", jsonOut["operationType"]) | ||
| s.Equal("BATCH_OPERATION_TYPE_TERMINATE_WORKFLOW", jsonOut["operationType"]) |
chaptersix
left a comment
There was a problem hiding this comment.
approving assuming the breaking change from the server is resolved.
52c3a14 to
6c1b164
Compare
Related issues
What changed?
Render links on activity describe- #1131
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableBefore:
After:
Before:
After: