[wip] Update workflow delete warning for passive-cluster rejection - #1154
Draft
jiechenz wants to merge 1 commit into
Draft
[wip] Update workflow delete warning for passive-cluster rejection#1154jiechenz wants to merge 1 commit into
jiechenz wants to merge 1 commit into
Conversation
The server now rejects DeleteWorkflowExecution on a cluster that is passive for the Workflow, so the old warning's advice -- target the passive cluster directly with `--grpc-meta xdc-redirection=false` -- no longer works. State the rule instead: only the Workflow's active cluster accepts the deletion, and requests sent to a passive cluster are forwarded there by default. Updated in both the runtime warning and the `workflow delete` long help, with commands.gen.go regenerated from commands.yaml. The standalone activity warning is left as is: DeleteActivityExecution has no equivalent restriction, so targeting a passive cluster still works there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server now rejects DeleteWorkflowExecution on a cluster that is passive for the Workflow, so the old warning's advice -- target the passive cluster directly with
--grpc-meta xdc-redirection=false-- no longer works. State the rule instead: only the Workflow's active cluster accepts the deletion, and requests sent to a passive cluster are forwarded there by default.Updated in both the runtime warning and the
workflow deletelong help, with commands.gen.go regenerated from commands.yaml.The standalone activity warning is left as is: DeleteActivityExecution has no equivalent restriction, so targeting a passive cluster still works there.
Related issues
What changed?
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
Setup
Happy path
Error case
Composition