Skip to content

fix(nexus-operations): make start standalone nexus operation timeouts optional#3656

Open
rossedfort wants to merge 3 commits into
mainfrom
fix-sano-timeout-validation
Open

fix(nexus-operations): make start standalone nexus operation timeouts optional#3656
rossedfort wants to merge 3 commits into
mainfrom
fix-sano-timeout-validation

Conversation

@rossedfort

Copy link
Copy Markdown
Contributor

Description & motivation 💭

The Start Standalone Nexus Operation form previously required that at least one of Start to Close or Schedule to Close timeout be set before the form could be submitted. This validation was too restrictive — all three timeout fields (Start to Close, Schedule to Close, Schedule to Start) should be optional, as the server can apply defaults.

Removed the Zod superRefine validation block that enforced the timeout requirement, the corresponding error display in the form, and the now-unused form-timeout-required i18n key.

Screenshots (if applicable) 📸

N/A

Design Considerations 🎨

None.

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  1. Navigate to the Start Standalone Nexus Operation form
  2. Fill in the required fields (Endpoint, Service, Operation Name)
  3. Leave all timeout fields empty
  4. Submit the form — it should succeed without any timeout validation errors

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

No docs updates needed.

@rossedfort rossedfort requested a review from a team as a code owner July 10, 2026 16:52
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jul 10, 2026 8:37pm

Request Review

@temporal-cicd

temporal-cicd Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 7 errors in 1 file (0.8% of 895 total)

src/lib/components/standalone-nexus-operations/start-standalone-nexus-operation-form/form.svelte (7)
  • L56:4: Type 'string | undefined' is not assignable to type 'string'.
  • L193:6: Type 'ClientValidationAdapter<{ encoding: "json/plain" | "json/protobuf"; namespace: string; endpoint: string; service: string; operation: string; identity: string; nexusHeader: { key: string; value: string; }[]; summary?: string | undefined; ... 8 more ...; idConflictPolicy?: string | undefined; }, { ...; }>' is not assignable to type 'ClientValidationAdapter<Partial<{ input: string; messageType: string; scheduleToStartTimeout: string; summary: string; details: string; idReusePolicy: string; idConflictPolicy: string; nexusHeader: never[]; encoding: "json/plain" | "json/protobuf"; ... 7 more ...; scheduleToCloseTimeout: string | undefined; }>, Reco...'.
  • L235:14: Type 'string | null | undefined' is not assignable to type 'string'.
  • L322:25: Type '{ key: string; value: string; }' is not assignable to type 'never'.
  • L322:47: Type '{ key: string; value: string; }' is not assignable to type 'never'.
  • L575:51: Property 'key' does not exist on type 'never'.
  • L584:51: Property 'value' does not exist on type 'never'.

Generated by 🚫 dangerJS against bad435c

@rossedfort rossedfort requested a review from Alex-Tideman July 10, 2026 17:01
…egration tests

Timeouts are now optional on the Start Standalone Nexus Operation form,
so the tests expecting timeout validation errors are no longer valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant