fix(nexus-operations): make start standalone nexus operation timeouts optional#3656
Open
rossedfort wants to merge 3 commits into
Open
fix(nexus-operations): make start standalone nexus operation timeouts optional#3656rossedfort wants to merge 3 commits into
rossedfort wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
…egration tests Timeouts are now optional on the Start Standalone Nexus Operation form, so the tests expecting timeout validation errors are no longer valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
The Start Standalone Nexus Operation form previously required that at least one of Start to Close or Schedule to Close timeout be set before the form could be submitted. This validation was too restrictive — all three timeout fields (Start to Close, Schedule to Close, Schedule to Start) should be optional, as the server can apply defaults.
Removed the Zod
superRefinevalidation block that enforced the timeout requirement, the corresponding error display in the form, and the now-unusedform-timeout-requiredi18n key.Screenshots (if applicable) 📸
N/A
Design Considerations 🎨
None.
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?
No docs updates needed.