Preserve saved progress when Edit State receives invalid JSON - #56
Open
Chessing234 wants to merge 1 commit into
Open
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting malformed JSON into Edit State currently clears saved exercise progress before parsing throws. Valid JSON such as
null, an array, or a scalar also clears progress without providing a usable state.Parse and validate a non-null JSON object before clearing storage. Invalid input displays an error and preserves progress; valid objects, including an intentional empty object, retain the existing import behavior.
Validation:
node --test tests/edit-state.test.jspasses all 8 tests. The six invalid-input cases fail on upstream master and pass with this change. The tests invoke the actual Edit State button callback with an isolated storage/DOM harness.node --check docs/js/gui.jsandgit diff --checkalso pass.