Skip to content

Optimize getInsertionIndex function parameters #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
381sm016 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize getInsertionIndex function parameters #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libthedesk/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* *************************************/
#include "common.h"

int Common::getInsertionIndex(QStringList preferredOrder, QStringList currentItems, QString item) {
int Common::getInsertionIndex(const QStringList& preferredOrder, const QStringList& currentItems, const QString& item) {
//First, check to see if there is a preferred order for this item
if (!preferredOrder.contains(item)) {
//No preferred order so just add it at the end
Expand Down
2 changes: 1 addition & 1 deletion libthedesk/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Common {
* @param item The name of the current item
* @return An index, or -1 to add to the end of the layout
*/
int getInsertionIndex(QStringList preferredOrder, QStringList currentItems, QString item);
int getInsertionIndex(const QStringList& preferredOrder, const QStringList& currentItems, const QString& item);
}

#endif // COMMON_H