This repository was archived by the owner on Jun 29, 2023. It is now read-only.
Conversation
github-actions
Bot
added
contracts
jacque006
force-pushed
the
contracts/bug-empty-user-state
branch
from
August 23, 2021 22:31
efd9681 to
2597253
Compare
jacque006
marked this pull request as ready for review
August 23, 2021 22:31
jacque006
changed the title
jacque006
force-pushed
the
contracts/bug-empty-user-state
branch
from
August 23, 2021 22:35
2597253 to
d3d3fa9
Compare
jacque006
marked this pull request as draft
August 24, 2021 15:39
Collaborator
Author
|
Re-working based on feedback #654 (comment) |
jacque006
force-pushed
the
contracts/bug-empty-user-state
branch
from
September 14, 2021 21:41
eb25b70 to
8898997
Compare
Add stateHash field to StateMerkleProof to allow proof to dispute empty to/from indexes. Sync some enums from Types.sol to match up in TS types in client. Add more extensive test cases for disputeTransitionTransfer for triggering rollbacks. Typo signautre -> signature.
jacque006
force-pushed
the
contracts/bug-empty-user-state
branch
from
September 22, 2021 01:07
75870d7 to
35097c8
Compare
ChihChengLiang
left a comment
ChihChengLiang
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. The Transition part looks solid.
Comment on lines
+10
to
+11
| bytes32 public constant ZERO_BYTES32 = | ||
| 0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563; |
Collaborator
There was a problem hiding this comment.
Good one moving ZERO_BYTES32 here
Comment on lines
+32
to
+35
| * @dev If this is not being externally consumed, it can be removed. | ||
| */ | ||
| // solhint-disable-next-line var-name-mixedcase | ||
| bytes32 public immutable ZERO_BYTES32; |
Collaborator
There was a problem hiding this comment.
Think we don't externally consume this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #654
TODO
Stack too deep, try removing local variables.error in numerous places.toIndexdispute test case.