fix: lower the meta constraint so the plugin fits flutter 3.41 - #364
Open
bschmalb-ksta wants to merge 1 commit into
Open
bschmalb-ksta wants to merge 1 commit into
bschmalb-ksta wants to merge 1 commit into
Conversation
The two native packages ask for meta ^1.18.0, which only the flutter 3.44 sdk ships. On 3.41 flutter_test pins meta to 1.17.0, so version solving fails and the plugin cannot be used at all. meta is only there for the immutable, protected and visibleForTesting annotations in the generated pigeon files, all of which have been in meta for many versions, so ^1.17.0 is enough and still resolves to 1.18 where that is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two native packages ask for meta ^1.18.0, which only the flutter 3.44 sdk ships. On 3.41 flutter_test pins meta to 1.17.0, so version solving fails and the plugin cannot be added to the app at all. meta is only there for the immutable, protected and visibleForTesting annotations in the generated pigeon files, all of which have been in meta for many versions, so ^1.17.0 is enough and still resolves to 1.18 where that is available.
Tested by resolving and building our own app, which is on flutter 3.41, against this branch, and by running the four packages' tests on 3.44 where it still picks meta 1.18.0.