Trigger release workflow on published, not just created - #101
Merged
Conversation
Publishing v0.8.0 from a draft fired the "published" event, not "created", so the Source Archive job silently never ran and the tarball/zip had to be attached by hand. Listening for both event types covers direct release creation and draft-then-publish alike.
|
coverage: 98.928%. remained the same — fix-release-workflow-trigger into main |
Contributor
|
created fires on any new release including drafts; published fires on any new release that isn't a draft. A direct (non-draft) release create fires both simultaneously, so listening to both would have run the job twice on the common path. published alone covers both the direct-create and draft-then-publish flows exactly once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publishing v0.8.0 from a draft release fired GitHub's
publishedevent, notcreated, sorelease.yml's Source Archive job never ran — the tarball/zip had to be attached by hand after the fact.createdfires on any new release, including drafts.publishedfires on any new release that is not a draft — covering both a direct (non-draft) release creation and a draft later transitioning to published, exactly once each. (A direct release creation fires bothcreatedandpublishedsimultaneously, so listening to both would run the job twice on the common path —publishedalone is the correct fix, not an addition.)Related Issues
N/A
Type of Change
Manual Verification (Optional)
Releaseworkflow run fired for either event under the oldtypes: [created]config. Manually ran the job's steps (cmake --preset GNU,cpack --preset source,gh release upload) to attach the missing assets.Checklist
docs/for any user-facing changes.mu::tinynamespace,INCLUDED_MU_TINY_guards,mutiny_C-prefix)..hand.c.cpp) is required for parity.CONTRIBUTING.mdfile to ensure compliance with architectural guidelines.