A question with an obvious answer is not asked - #24
Merged
Merged
Conversation
The screen already refuses to show a control that would be ignored. This is the same rule pointed at questions. Every planned conversion is read as five facts - is something being thrown away, did the user ask for that themselves, is anything undefined, does this make a different kind of thing or more files than it was given, does it touch the originals - and those five decide between running it, asking once, and the existing replace-or-move dialog. The case it is built for: drop a folder onto a preset chosen a minute ago and nothing is asked at all. A size the user typed into a filename counts as their answer, so `holiday_10MB.jpg` runs; the same ceiling arriving from a preset does not, and gets one sober popup with what it actually costs. That popup runs the real chain on one representative file per kind into a scratch folder, so the before and after are measured rather than guessed, and it is not written into anybody's history. A film is the exception: encoding one to show what encoding it looks like is the conversion itself, done twice, so it gets a frame and a sentence. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018H9CZxWumc3ryumgEHd578
…econd one Routing every drop through the gate meant that files dropped while a batch was running went straight to "nothing to ask, run it" - a second batch over the same list, two conversions racing for the same output names, the second reporting files the first had not finished writing. Guarded in both places it can happen: the screen does not route a drop while it is busy, and the batch itself refuses to start twice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018H9CZxWumc3ryumgEHd578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screen already refuses to show a control that would be ignored. This is the same rule pointed at questions.
Every planned conversion is read as five facts — is something being thrown away, did the user ask for that themselves, is anything undefined, does this make a different kind of thing or more files than it was given, does it touch the originals — and those five decide between running it, asking once, and the existing replace-or-move dialog.
holiday_10MB.jpgcounts as the user's own answer, so it runs.Also fixed here: a drop during a running batch used to route straight to "nothing to ask, run it" — a second batch over the same list, racing for the same output names. Guarded on the screen and in the batch itself.
Test plan
swift test— 279 tests green🤖 Generated with Claude Code
https://claude.ai/code/session_018H9CZxWumc3ryumgEHd578