Conversation
ppannuto
requested changes
Sep 11, 2026
| // Offset each pin's starting phase within the pulse so pins do not all | ||
| // pulse in lockstep. | ||
| uint32_t phase_offset = PULSE_STEPS / count; | ||
| if (phase_offset == 0) phase_offset = 1; |
Member
There was a problem hiding this comment.
Suggested change
| if (phase_offset == 0) phase_offset = 1; |
weird check for an impossible condition (PULSE_STEPS can't be 0, both because it makes no sense and because it's the divisor of a mod higher in this file so you'd get a compile-error if you tried).
Comment on lines
+12
to
+13
| // Maximum duty cycle accepted by the PWM driver (100.00%). | ||
| #define MAX_DUTY_CYCLE 10000 |
Member
There was a problem hiding this comment.
This should be in pwm.h, it's part of the interface contract of the driver, not specific to this example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds libtock support for PWM and adds a test app for pulsing LEDs via PWM. I'm not entirely sure why we didn't have this support before.
This is all claude. It's just so much faster at creating this rote code. I've tested this with the kernel and even sent a video of the leds pulsing.