PM-5370 - return winner placement - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the campus leaderboard report to track and display all placements (not just wins) for Topcoder challenges, and adds tests to ensure non-winning placements are correctly handled. The changes also clarify the definition of a "win" in the leaderboard logic.
Leaderboard SQL logic updates:
member_winsis renamed tomember_placementsand now includes all placements, not just first place. The logic for determining a "win" is updated to check forplacement = 1instead of filtering at the SQL level.participationCTE and all related joins are updated to usemember_placementsinstead ofmember_wins, ensuring all placements are considered throughout the report. [1] [2]wonfield in the leaderboard output is now computed aswin.member_id IS NOT NULL AND win.placement = 1, so only first-place finishes are counted as wins, while other placements are still tracked.Test coverage improvements: