PM-5370 campus leaderboard - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes two main improvements to the campus leaderboard report for Topcoder: (1) it adds a new field to indicate whether each submission has been reviewed, and (2) it simplifies access controls so that any authenticated user can read campus program leaderboards, including private groups. The changes include updates to SQL queries, TypeScript service logic, DTOs, and tests to support these features.
Campus leaderboard review status enhancements:
reviewedfield to the leaderboard report, which indicates whether a submission has been reviewed (as opposed to simply passing or failing review). This is reflected in the SQL (campus-leaderboard.sql), service types, and DTOs, and is covered by new and updated tests. [1] [2] [3] [4] [5] [6] [7] [8] [9]Access control simplification:
campus-leaderboard-group.sql), the service, and the controller, as well as updating tests to reflect the new behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9]Test and code cleanup:
DTO formatting improvements:
leaderboard-generic.dto.tsandleaderboard-mm.dto.ts. [1] [2]