Skip to content

PM-5370 campus leaderboard - #148

Merged
vas3a merged 3 commits into
developfrom
PM-5370_campus-leaderboard
Aug 26, 2026
Merged

PM-5370 campus leaderboard#148
vas3a merged 3 commits into
developfrom
PM-5370_campus-leaderboard

Conversation

@vas3a

@vas3a vas3a commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

This pull request makes two main improvements to the campus leaderboard report for Topcoder: (1) it adds a new field to indicate whether each submission has been reviewed, and (2) it simplifies access controls so that any authenticated user can read campus program leaderboards, including private groups. The changes include updates to SQL queries, TypeScript service logic, DTOs, and tests to support these features.

Campus leaderboard review status enhancements:

  • Added a new reviewed field to the leaderboard report, which indicates whether a submission has been reviewed (as opposed to simply passing or failing review). This is reflected in the SQL (campus-leaderboard.sql), service types, and DTOs, and is covered by new and updated tests. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Access control simplification:

  • Removed the requirement for group membership or special report access to view private campus group leaderboards; now, any authenticated user can access them. This involved removing related logic from the SQL (campus-leaderboard-group.sql), the service, and the controller, as well as updating tests to reflect the new behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Test and code cleanup:

  • Removed unused imports and parameters related to the old access control logic, and updated tests to match the new API and expected behaviors. [1] [2] [3]

DTO formatting improvements:

  • Reformatted DTO imports for readability in leaderboard-generic.dto.ts and leaderboard-mm.dto.ts. [1] [2]

@vas3a
vas3a merged commit e5b8be0 into develop Aug 26, 2026
5 checks passed
@vas3a
vas3a deleted the PM-5370_campus-leaderboard branch August 26, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant