Inlining queries for the (fully) implicit triangulation - #972
Merged
julien-tierny merged 12 commits intoSep 29, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR inlines some queries in the implementation of the (fully) implicit triangulation.
As discussed in the PR #971, this results in a 15% gain for discrete gradient computation (in parallel, 24 cores) on a 512³ dataset (ctBones, tested: bitwise compatibility on the output with the dev branch).
Note that, as discussed at the end of PR #971, several experiments (for instance, see the commits up to 57d7181) were made to further inline this class. However this resulted in a decreased gain (possibly due to the size of the inlined code saturating the cpu cache).