⚡ Bolt: [performance improvement] Replace O(n) array filter with O(log n) binary search#74
⚡ Bolt: [performance improvement] Replace O(n) array filter with O(log n) binary search#74toreleon wants to merge 2 commits into
Conversation
Implements `findLastBarIndex` binary search in `dnsePublic.ts` and updates the backtesting runner and `clipBars` to use it instead of `.filter()`. This prevents creating large temporary arrays on every invocation inside the hot loop and drops the lookup time from O(n) to O(log n). Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implements `findLastBarIndex` binary search in `dnsePublic.ts` and updates the backtesting runner and `clipBars` to use it instead of `.filter()`. This prevents creating large temporary arrays on every invocation inside the hot loop and drops the lookup time from O(n) to O(log n). fix: update dependencies to resolve security vulnerabilities reported by pnpm audit Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
1 participant
💡 What: Replaced O(n)
Array.prototype.filter()with an O(log n) binary search function (findLastBarIndex) for looking up historical price data indnsePublic.tsandbacktestRunner.ts.🎯 Why: Inside the backtest runner's hot loop,
.filter()was being called on every ticker for every interval, traversing the entire time-series array and creating unnecessary intermediate arrays just to get the last matching element.📊 Impact: Substantially reduces CPU usage and memory churn during long backtests by replacing an O(N) allocation with a zero-allocation O(log N) lookup.
🔬 Measurement: Run a backtest using
npx tsx src/agent/backtestRunner.tsor view the terminal UI backtest feature (/backtest). Observe memory usage and CPU time. Tests verify correctness (pnpm test).PR created automatically by Jules for task 5297929692272528072 started by @toreleon