Convert DIP inch and centimeter dimensions to millimeters - #883
Open
Danty-pig123 wants to merge 1 commit into
Open
Danty-pig123 wants to merge 1 commit into
Danty-pig123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
dip4_w0.3ininput produces 0.3 mm between pin rows instead of 7.62 mm. DIP's custom parser only converts mils and treats other unit suffixes as millimeters.Use Circuit JSON's length parser for row width, pitch, hole diameter and pad diameter. Retain case-insensitive mil inputs. Add numeric geometry checks for inch/centimeter inputs through the string and builder APIs, plus two SVG snapshots.
The new regressions fail on the original source. All 20 focused DIP tests pass with Bun 1.3.5, as do the package/declaration build and formatting. The full suite has 569 passes and four SVG mismatches (
smf,parity/qfn32_thermalpad3.1x3.1mm,parity/sod523,diode-kicad-parity/sod523); the unchanged baseline has the same four failures with 560 passes.Linux CI has 572 passes and only the QFN32 SVG mismatch. That same failure occurs on the unchanged production base in September 11 CI, whose only added file is an unrelated SOIC test. Build and formatting checks pass.