fix: honor length units in SOD pad dimensions - #887
Open
santosh-kumar-git wants to merge 1 commit into
Open
santosh-kumar-git wants to merge 1 commit into
santosh-kumar-git wants to merge 1 commit into
Conversation
santosh-kumar-git
requested review from
seveibar and
techmannih
as code owners
September 15, 2026 07:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOD pad dimensions and pitch currently discard unit suffixes with
Number.parseFloat. For example,fp.string("sod123_pl0.02in_pw0.01in_p0.1in")produces 0.02 × 0.01 mm pads at x = ±0.05 mm instead of 0.508 × 0.254 mm pads at x = ±1.27 mm.Use the existing
length.parseconversion for pad length, width and pitch in the 12 affected SOD generators. Existing millimeter defaults remain unchanged. Add literal dimension assertions and SVG snapshots for each affected variant, plus a public string-parser regression using mils.Validation:
bun run buildandbiome format .pass.parity/qfn32_thermalpad3.1x3.1mmsnapshot failure also reproduces on unchanged upstreamd0d2ee1with the same dependencies.tsc --noEmitreports 264 existing errors; its complete output is identical on unchanged upstream.Tested with Bun 1.4.2; all 12 new SVG snapshots were visually inspected.