Skip to content

feat: add explicit two-pad package identities - #888

Merged
rushabhcodes merged 3 commits into
tscircuit:mainfrom
rushabhcodes:fix/explicit-two-pad-package-identity
Sep 16, 2026
Merged

rushabhcodes merged 3 commits into
tscircuit:mainfrom
rushabhcodes:fix/explicit-two-pad-package-identity

Conversation

@rushabhcodes

Copy link
Copy Markdown
Contributor

Closes #884

Summary

  • add canonical do219ad and sod323he footprint families while preserving generic smdpads2 behavior
  • add validated land-pattern, mechanical-dimension, and polarity parameters
  • extend explicit dfn2 definitions with optional physical package dimensions
  • reject unsupported package parameters instead of silently accepting suffixes
  • document canonical and hyphenated spellings

Validation

  • bun test tests/standard-two-pad-packages.test.ts tests/string-parser.test.ts tests/footprint-completeness.test.ts
  • bun run build
  • bunx biome check ...
  • visually inspected SVG snapshots for DO-219AD, SOD-323HE, and DFN2

Downstream

A linked jscad-electronics PR will wire these canonical identities into Footprinter3d.

Copilot AI lite review requested due to automatic review settings September 16, 2026 01:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread tests/standard-two-pad-packages.test.ts
@rushabhcodes
rushabhcodes force-pushed the fix/explicit-two-pad-package-identity branch from 10d69dd to 6d632c6 Compare September 16, 2026 01:52
@rushabhcodes

Copy link
Copy Markdown
Contributor Author

Downstream Footprinter3d integration is open as tscircuit/jscad-electronics#378.

@rushabhcodes
rushabhcodes merged commit 43e0954 into tscircuit:main Sep 16, 2026
5 checks passed
@rushabhcodes
rushabhcodes deleted the fix/explicit-two-pad-package-identity branch September 16, 2026 07:36
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support explicit package identity for ambiguous two-pad 3D model integration

4 participants