Conversation
penberg
approved these changes
Jul 30, 2026
2 tasks done
pedrocarlo
added a commit
that referenced
this pull request
Sep 28, 2026
## Summary - Route `turso db tokens invalidate <database>` to the database-scoped rotation endpoint for grouped as well as ungrouped databases, rather than refusing grouped databases or substituting group rotation. - Correct the database confirmation: database-scoped tokens need replacement; group tokens are unaffected. Do not claim replica restarts or downtime. - Clarify `turso group tokens invalidate` help, confirmation, and success output: this invalidates group tokens but not necessarily database-scoped tokens. To revoke the latter, run `turso db tokens invalidate <database-name>` for each database. Avoid claiming all database connections drop or that downtime occurs. - Add command-level and endpoint tests for grouped databases and the legacy dedicated-cluster error. ## Testing - [x] `go test ./... -count=1` - [x] `git diff --check` ## Caveat Legacy dedicated grouped clusters reject individual database credential rotation (HTTP 400). The CLI propagates that error without silently rotating group credentials. Their group rotation can affect database tokens through a shared cluster key, which is why the guidance says "not necessarily". Related: #1064 touches the same command with a server-type gate; this PR uses the database endpoint as the source of support instead. Amp thread: https://ampcode.com/threads/T-01a0e943-2130-70ed-8b52-4fb27500934a
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turso-server support db tokens invalidation