Conversation
Two IOSuite tests take the Left remainder from syncStep, cancel it, and assert that the Resource release ran. The release does not run today, so both are tagged .fail.pending until the interpreter is fixed.
Same shape as the onCancel tests: split IO.uncancelable(_ => IO.never) with syncStep and cancel the remainder from another fiber. The original blocks the cancel on the mask; the remainder lets it through.
tobiajo
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three
IOSuitetests split anIOwithsyncStepand cancel what comes back. Two use aResource.use, canceled from inside and from another fiber, and assert that the release ran. The third usesIO.uncancelableand asserts that a cancel from another fiber blocks on the mask. None holds today, so all are tagged.fail.pending. OncesyncStepis fixed they fail with "expected failure" and the tag can be dropped.Pins #4687.