Conversation
Add a check that prevent searcher thread from stealling from other thread or from external queue when it queue is no longer empty. The current behavior cause a forver spin of searcher thread when expiring timer fill all the local queue issue discussed here #issues/4674
Contributor
|
@armanbilge , @djspiewak , looks like we have the answer to this question!
|
reardonj
approved these changes
Sep 25, 2026
reardonj
left a comment
reardonj
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me.
| // First try to steal some expired timers. | ||
| val stoleTimers = pool.stealTimers(now, rnd) | ||
|
|
||
| // Stolen timer callbacks resume fibers, and resumed fibers are |
Contributor
There was a problem hiding this comment.
Do stolen timer callbacks always resume fibers? Wondering if we could just check stoleTimers instead of queue.nonEmpty()
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check that prevent searcher thread from stealling from other thread or from external queue when it queue is no longer empty. The current behavior cause a forver spin of searcher thread when expiring timer fill all the local queue
issue discussed here #issues/4674