-
Notifications
You must be signed in to change notification settings - Fork 24
🎨 Add blkt pipes output #4369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris-ashe
wants to merge
33
commits into
main
Choose a base branch
from
add_blkt_pipes_output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🎨 Add blkt pipes output #4369
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7f66c24
Move elbow coeffieicnt calc from blanket to pumping
chris-ashe 693d5ca
Add coolant properties to BlanketData class
chris-ashe f3bcda6
Add coolant friction loss parameters and output functions for blanket…
chris-ashe d23fc88
Add function to plot blanket coolant channel structure and update mai…
chris-ashe 992e8b2
Refactor pressure drop assertions in blanket tests for clarity and co…
chris-ashe 8d84409
Add function to plot outboard blanket coolant properties along the po…
chris-ashe 8ab606f
Tidy some variable names to match style guide
chris-ashe 7b10286
Create mass flow required function and implement
chris-ashe 595ddf2
🔄 Rename FW and Blkt heat capacity variables
chris-ashe 23740c9
Add output for outboard blanket piping
chris-ashe 641860c
Add output table for outboard blanket
chris-ashe 7dabfcb
Refactor coolant friction loss parameters and update related tests
chris-ashe 53ceec1
Enhance inboard blanket coolant channel output and pressure drop calc…
chris-ashe 5966913
Move FW number of bends to FW file
chris-ashe 9bdc028
Remove pipe plotting
chris-ashe a72f44e
Update summary positions of tables
chris-ashe e3f5762
Post rebase fixes
chris-ashe 622b957
Remove unused CoolProp imports and related plotting functions for out…
chris-ashe 02f1a1f
Post merge coflict fixes
chris-ashe 775f652
Move all of the pumping related function from `BlanketLibrary` into t…
chris-ashe 2033ce5
Update some output formatting
chris-ashe 96c3b10
Fix some coolant pumping power function imports
chris-ashe a02897d
Refactor pumping outputs to be specifically for inboard and outboard …
chris-ashe bdfa340
Add coolant mass flow rate output
chris-ashe 8de7197
Refactor coolant pumping power types to use CALCULATE_PRESSURE_DROP a…
chris-ashe 0c82b7e
Rename mass flow rate variables for clarity in blanket model
chris-ashe 539fb4f
Add coolant mass flow rate and velocity outputs for single channels i…
chris-ashe 9944ab1
Post rebase fixes
chris-ashe 2f0d153
Only output pumping variables if pressure drop is calculated
chris-ashe ca7110f
Add pumping power calculation option output in first wall pumping det…
chris-ashe db47075
Update process/models/blankets/blanket_library.py
chris-ashe 94feec4
Refactor blanket models to use pipe_hydraulic_diameter function and a…
chris-ashe 01352c5
Remove unnecessary @staticmethod decorators from calculate_reynolds_n…
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this bit of doc is new, so probably worth an @ukaea/process-model-review looking at it