Add matches to all pytest.raises in test_input - #4553
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4553 +/- ##
==========================================
+ Coverage 49.46% 49.47% +0.01%
==========================================
Files 150 150
Lines 30069 30069
==========================================
+ Hits 14874 14878 +4
+ Misses 15195 15191 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
approved these changes
Aug 25, 2026
dallonby
added a commit
to dallonby/PROCESS
that referenced
this pull request
Aug 25, 2026
…er tests skip validation - The check no longer exempts ixc = 13: the input value seeds the first model evaluation either way; an exactly-zero value was only caught later by the generic iteration-variable check, and a negative value was not caught at all (the 1/value scaling in load_iteration_variables inverts the variable's bounds). Rejecting at input validation covers both with an actionable message. - The error message drops "or use ixc = 13" accordingly. - The conductor-model condition is removed: dr_tf_inboard is only derived under ixc = 140 or for stellarators, neither of which depends on i_tf_sup, so resistive TF coils had the same silent zero-thickness path. - test_input.py keeps its scaffold unchanged and instead disables check_process with an autouse monkeypatch fixture, as suggested; the parser tests no longer carry TF geometry. - Tests updated: resistive zero-thickness now rejected (plus an accepted positive-thickness case), and ixc = 13 with zero or negative input is rejected. Unit suite 855 passed / 4 skipped; integration 21 passed / 1 skipped (all shipped regression inputs pass the widened check). Rebased onto main (includes ukaea#4553). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.