[WIP] Video: xy point improvements - #322
Draft
abdullah-ukaea wants to merge 13 commits into
Draft
Conversation
…te 5 point editor host.
abdullah-ukaea
marked this pull request as ready for review
July 13, 2026 10:20
Collaborator
Author
Collaborator
Author
|
Not ready for code review |
Collaborator
|
I'll leave this to @SteveAEA to functionality test properly, but I've had a quick go and it looks really good! Much better than before :) Couple things:
toktagger_selecting_points.mp4
Example of points 2, 3, 4: Video.Project.50.mp4(Side note related to 2 - I've just noticed that bounding boxes & polygons can be deleted in View mode. That probably shouldn't be the case - I think the ideal scenario is that the pop up still appears in View mode if the item is clicked, but the delete button is disabled) |
Collaborator
Author
|
New updates will come shortly to this PR after some other video PRs are merged to dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
@annotorious/plugin-toolsdependency and replaces it with a small point editor we own, built for x,y keypoint annotation.point-editor/module: a Svelte 5 editor component, a React overlay that draws all point markers, and shared marker style constants.point-editor-host.svelte.ts) presents our Svelte 5 editor to Annotorious in the shape it expectsDemo
xy_point_part2.mp4