Skip to content

[WIP] Video: xy point improvements - #322

Draft
abdullah-ukaea wants to merge 13 commits into
devfrom
video/xy-point-ii
Draft

[WIP] Video: xy point improvements #322
abdullah-ukaea wants to merge 13 commits into
devfrom
video/xy-point-ii

Conversation

@abdullah-ukaea

Copy link
Copy Markdown
Collaborator

Summary

Removes the @annotorious/plugin-tools dependency and replaces it with a small point editor we own, built for x,y keypoint annotation.

  • New point-editor/ module: a Svelte 5 editor component, a React overlay that draws all point markers, and shared marker style constants.
  • Point markers are now drawn in screen pixels: a ring with a centre dot that stays the same size at any zoom, in both view and edit mode.
  • Selected points are highlighted (blue ring).
  • Crosshair cursor when the point tool is armed.
  • Deletes the CSS hacks we used to hide the old editor's resize handles.
  • Adds Svelte 5 to the build. Annotorious expects Svelte 4 style editor components and Svelte's own 4 to 5 compatibility helpers are deprecated, so a small adapter (point-editor-host.svelte.ts) presents our Svelte 5 editor to Annotorious in the shape it expects

Demo

xy_point_part2.mp4

@abdullah-ukaea
abdullah-ukaea marked this pull request as ready for review July 13, 2026 10:20
@abdullah-ukaea

Copy link
Copy Markdown
Collaborator Author

For now, no code review is required.

Please can @SteveAEA @jblake42 first functionally test this branch / use the new x,y point annotation. Identify any bugs, make sure the expected features are working.

@abdullah-ukaea abdullah-ukaea added the enhancement New feature or request label Jul 16, 2026
@abdullah-ukaea abdullah-ukaea changed the title Video Annotation: X,Y point improvements Video: xy point improvements Jul 23, 2026
@abdullah-ukaea

Copy link
Copy Markdown
Collaborator Author

Not ready for code review

@wk9874

wk9874 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

I'll leave this to @SteveAEA to functionality test properly, but I've had a quick go and it looks really good! Much better than before :) Couple things:

  1. I find it quite hard to click an existing point when fully zoomed out - it looks like this might be because the 'hitbox' is only the very central dot, rather than the whole outer circle? Can this be improved?
toktagger_selecting_points.mp4
  1. Points are only selectable in edit mode, while other items are selectable in both modes
  2. Points are rendered over the top of info box popups, which is different to other items
  3. Sometimes points seems unselectable, even in edit mode

Example of points 2, 3, 4:

Video.Project.50.mp4

(Side note related to 2 - I've just noticed that bounding boxes & polygons can be deleted in View mode. That probably shouldn't be the case - I think the ideal scenario is that the pop up still appears in View mode if the item is clicked, but the delete button is disabled)

@abdullah-ukaea

Copy link
Copy Markdown
Collaborator Author

New updates will come shortly to this PR after some other video PRs are merged to dev.

@abdullah-ukaea abdullah-ukaea changed the title Video: xy point improvements [WIP] Video: xy point improvements Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants