Icod.Terminal 1.0.0 — Windows PowerShell 5.1 Validation Compatibility - #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the local
build.cmd/ Debug validation failure discovered after stable PR #34 merged.Problems
packaging/VerifyLicenseHeaders.ps1had two assumptions that were valid under PowerShell 7/.NET but not under Windows PowerShell 5.1:[System.IO.Path]::GetRelativePath(...), which does not exist in the .NET Framework runtime used bypowershell.exe;The first failure was observed locally as:
The new Windows PowerShell 5.1 regression job then exposed the newline mismatch, allowing both compatibility defects to be fixed before publication.
Fix
Path.GetRelativePathcalls with a repository-localGet-RepositoryRelativePathhelper built from APIs available in Windows PowerShell 5.1;Regression coverage
The Windows PR runtime job now explicitly runs:
before the existing PowerShell 7 runtime validation. This makes Windows PowerShell 5.1 compatibility an enforced PR contract rather than relying on
pwsh-only hosted validation.On exact head
e49a8b72646551925310b0b0854f822e8e030a72, workflow #978 (34200260312) has already passed the explicit Verify license headers under Windows PowerShell 5.1 step. The remaining normal runtime/package jobs continue to validate the unchanged stable 1.0 package/API contracts.This PR is a pre-publication build/validation compatibility fix for stable
1.0.0; it contains no product-source or API changes.