Replace gen_leader with locks_leader for gproc_dist - #207
Open
uwiger wants to merge 6 commits into
Open
Conversation
Port distributed registry to locks_leader: optional locks application,
conditional gproc_dist start when locks_server is present, and optional
peer connect via {gproc, gproc_dist} node list.
Testing: Common Test gproc_dist_SUITE with peer nodes and per-node
disk logs; eunit keeps local coverage (dist eunit generator removed).
Drop rebar.config.script that previously gated gen_leader.
Stop ignoring rebar.lock so CI and clones pin locks (and plain_fsm) to the same refs as development.
wait_gproc_leader now probes with a long-lived process until a global name is visible on every node (leader agreement alone is not enough; broadcast only reaches synced followers). Increase lookup retries for CI load. Upload _build/test/logs as an artifact when make fails.
vkatsuba
reviewed
Aug 7, 2026
| image: erlang:${{ matrix.otp }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
Minor stuff but still, since this version is updated it make sense to use latest version of component
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v7 |
If you check Summary of last CI run(https://github.com/uwiger/gproc/actions/runs/30544178216?pr=207) you can see Warning like
[OTP 27](https://github.com/uwiger/gproc/actions/runs/30544178216/job/90876025774#step:11:2)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Using latest version of component should fix this warning and future issues with CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port distributed registry to locks_leader: optional locks application,
conditional gproc_dist start when locks_server is present, and optional
peer connect via {gproc, gproc_dist} node list.
Testing: Common Test gproc_dist_SUITE with peer nodes and per-node
disk logs; eunit keeps local coverage (dist eunit generator removed).
Drop rebar.config.script that previously gated gen_leader.