Skip to content

Refactor RTS scan_through_elements_helper to struct #2720

Description

@danhoeflinger

Here's what I propose (I'll make an issue):
In a separate PR, create a struct which encapsulates this in two layers:

  1. struct scan_through_elements_helper- created once per kernel, with a few public entry points which have template arguments for the constexpr fields which change from invocation to invocation within a kernel (__init_present for instance). Pull in the 2 usages of dispatch as named functions of this struct, to allow it to be a private helper.

  2. struct sub_group_scan - toggle on or off inclusive_scan at the struct level, with 2 public entry points for scan and partial_scan, each templated with __init_present.

I think it makes sense to wait until after #2657, since some template parameters go away with that PR.

Originally posted by @danhoeflinger in #2709 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions