[DAR-7748] fix: use bash shell for env var in build workflow - #23
Merged
Merged
Conversation
- build.yml: Add `shell: bash` to Set env step so bash parameter expansion works on Windows (was silently failing in PowerShell) - deploy.yml: Download artifacts to dist-raw/ then flatten into dist/ so pypi-publish doesn't choke on subdirectories. Remove unsupported merge_multiple parameter from dawidd6/action-download-artifact. Made-with: Cursor
umbertoDifa
force-pushed
the
fix/windows-build-env
branch
from
April 9, 2026 08:27
9573bba to
c857ee7
Compare
umbertoDifa
changed the title
mickeypash
self-requested a review
April 9, 2026 09:04
mickeypash
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DAR-7748
Fixes two CI issues discovered during the v0.2.0 release:
build.yml: The
Set envstep uses bash parameter expansion (${GITHUB_REF#refs/*/}) which doesn't work in PowerShell (Windows default shell). Addingshell: bashensures the step works on all platforms. This caused Windows wheel artifacts to not be uploaded.deploy.yml: The
dawidd6/action-download-artifact@v6downloads each matching artifact into its own subdirectory. Thepypa/gh-action-pypi-publishaction then fails because it encounters directories instead of.whl/.tar.gzfiles. Fixed by downloading todist-raw/and flattening intodist/. Also removed unsupportedmerge_multipleparameter.Test plan