Skip to content

fix: fail build when plot options schemas are not generated - #10049

Merged
tomivirkki merged 1 commit into
mainfrom
fix/plot-options-schema-guards
Sep 8, 2026
Merged

fix: fail build when plot options schemas are not generated#10049
tomivirkki merged 1 commit into
mainfrom
fix/plot-options-schema-guards

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Summary

  • The chart plot options schemas are generated at build time from the chart model sources and shipped in the jar. When the source directory was missing the generator only logged a warning and skipped, so a build with tests skipped could publish a jar without schemas and the tool would report every chart type as unknown. The generator now fails the build in that case, and a missing resource at runtime is logged as an error.
  • Added tests that check the generated resource is on the classpath, covers every supported chart type with descriptions, and is exposed through ChartAIController's tools, so a regression in generation or packaging fails the module's unit tests directly.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@tomivirkki
tomivirkki added this pull request to the merge queue Sep 8, 2026
@ugur-vaadin

Copy link
Copy Markdown
Contributor

Should we also target v25.3?

Merged via the queue into main with commit 6183bd3 Sep 8, 2026
23 checks passed
@tomivirkki
tomivirkki deleted the fix/plot-options-schema-guards branch September 8, 2026 11:55
@tomivirkki

Copy link
Copy Markdown
Member Author

Should we also target v25.3?

I was originally planning to exclude it from 25.3, but shouldn't hurt to have it there either. Let's keep the CP PR in draft for a while just to be sure it doesn't affect build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants