Error out if the variant does not exist in git#764
Merged
openshift-merge-bot[bot] merged 3 commits intoJul 9, 2026
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tested with:
main:
clusterGroupName: broken
And got:
conditions:
- lastTransitionTime: "2026-07-08T14:55:04Z"
lastUpdateTime: "2026-07-08T14:56:05Z"
message: 'required values file not found: values-broken.yaml'
status: "True"
type: Missing
Also tested with a correct clusterGroupName and got a correct
deployment.
mbaldessari
force-pushed
the
errorout-on-wrong-variant
branch
from
71a3252 to
b69714f
Compare
After git fetch, only refs/remotes/origin/<branch> is updated while refs/heads/<branch> stays at the old commit. getCommitFromTarget was checking the local branch ref first, so reconcile loops kept checking out a stale commit even after new changes were pushed to the remote. Reorder reference resolution to prefer the remote tracking ref, which reflects the latest fetched state.
Contributor
|
/lgtm |
openshift-merge-bot
Bot
merged commit c67fb23
into
validatedpatterns:main
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with:
And got:
Also tested with a correct clusterGroupName and got a correct
deployment.