Add optional complex field output to coherent and Huygens PSF models - #118
Open
changlaplace wants to merge 1 commit into
Open
Add optional complex field output to coherent and Huygens PSF models#118changlaplace wants to merge 1 commit into
changlaplace wants to merge 1 commit into
Conversation
Collaborator
|
Thank you! I will review it as soon as I have time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepLens currently computes complex fields internally for both coherent PSF models, but only exposes the final intensity PSF. This prevents users from accessing sensor-plane phase information needed for coherent imaging tasks such as field propagation, interference, phase modulation, and custom wave-optics pipelines.
This PR exposes the already-computed sensor-plane field without introducing a new propagation path.
Changes
return_field=Truesupport to:model="coherent"model="huygens"sensor_fieldinpsf_pupil_prop().sum(abs(field) ** 2) ≈ 1.return_field=False.Compatibility
return_fielddefaults toFalse, so existing calls and intensity outputs remain unchanged. No other PSF models or propagation implementations are modified.Tests
Added focused coverage verifying that:
abs(field) ** 2matches the corresponding default intensity output;