Flag to store a deep copy of the request body in the response - #1350
Merged
thomasht86 merged 3 commits intoSep 21, 2026
Merged
Conversation
thomasht86
self-requested a review
September 21, 2026 08:23
thomasht86
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
When replaying a lot of queries, it can be useful to be able to match the request with the response.
When replaying queries in async mode, maintaining the mapping is pretty tricky and needs monkey patching pyvespa library.
VespaResponseobject already has a slot for therequest_body.This PR adds an option parameter, to save a deep copy of the
request_body.The downside is that with big requests bodies it causes increased memory usage.