running go fix for the code - #98
Merged
Merged
Conversation
dtitov
approved these changes
Aug 25, 2026
There was a problem hiding this comment.
Pull request overview
Updates the codebase according to go fix ./..., modernizing Go type usage and adopting newer standard-library helpers to simplify common patterns.
Changes:
- Replaced
interface{}withanyacross public/internal DB/test helper interfaces and query utilities. - Updated migration splitting to use
strings.SplitSeqto iterate over migration segments without allocating a full slice. - Simplified tag matching logic using
slices.Contains.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sqltest/querydump.go | Migrates loosely-typed row/query helpers from interface{} to any and minor loop cleanup. |
| sqltest/intf.go | Updates CtxExecer/CtxQuerier signatures to ...any for modern Go typing. |
| sqltest/fixture.go | Uses strings.SplitSeq for iterating migration chunks. |
| sqlparser/parser.go | Uses slices.Contains to simplify include-tag matching. |
| dbintf.go | Updates the main DB interface method varargs from interface{} to any. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go fix ./...