Nbd: update to 3.27.1#59515
Open
vincele wants to merge 4 commits into
Open
Conversation
vincele
force-pushed
the
nbd
branch
3 times, most recently
from
133915e to
fe7b962
Compare
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
- new version
- move from sourceforge to github
- add gnutls library
- fix compilation warning, by removing CFLAGS addition:
```
<command-line>: warning: "PROG_NAME" redefined
<command-line>: note: this is the location of the previous definition
```
- fix compilation by adding libnl3 which is detected by configure script
and defines macros modifying the code. Error was:
```
nbd-client.c: In function 'main':
nbd-client.c:1723:32: error: implicit declaration of function
'persist_mode_main' [-Wimplicit-function-declaration]
1723 | return persist_mode_main(index,
sockfds, flags);
| ^~~~~~~~~~~~~~~~~
```
NETLINK-related compilation problem reported upstream, with a proposed fix:
NetworkBlockDevice/nbd#183
- allow forking worker pool, parent process should still stay in the foreground - no need to re-redirect stderr a second time
- use the tagged archive - autoreconf - add required build dependencies - avoid the need for git at build time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And assorted changes:
whichI separated the runit tweaks in their own commit, is that useful or should I squash everything together ?
Testing the changes
Tested localhost self- export & mount from void x86_64-musl.
Tested mounting on openwrt 25.12.1 (mipsel_24kc) from the x86_64-musl host exports.
Of two different file-based exports, one simple, the other with templated name.
Also tested a real block device (a partition from a SATA SSD drive) exported from the nbd-server on the OpenWRT host and mounted to the x86_64-musl void one.
OpenWRT has different versions:
All tests ran properly.
Local build testing
CI Build failure log analysis
The i686 failure is in the check phase, one of the tests FAIL'ed.
with: