Skip to content

feat(android): remember reading position - #44

Open
jiasheny wants to merge 1 commit into
vorojar:masterfrom
jiasheny:codex/android-reading-position
Open

jiasheny wants to merge 1 commit into
vorojar:masterfrom
jiasheny:codex/android-reading-position

Conversation

@jiasheny

Copy link
Copy Markdown

Summary

  • persist normalized reading progress per Android document in a dedicated SharedPreferences store
  • keep the source document key on cached Recent entries so reopening either path resumes at the same place
  • debounce scroll saves, flush before backgrounding/document switches, and restore after deferred renderer/image layout changes
  • add Playwright regression coverage and update Android/mobile documentation

Verification

  • node mobile/scripts/verify-mobile-renderer.mjs — passed (repeated 3 times)
  • gradle :app:assembleDebug --no-daemon — passed
  • git diff --check — passed
  • gradle :app:lintDebug --no-daemon — reaches lint, then reports the existing AppLinkUrlError for the unchanged file:// intent filter at AndroidManifest.xml:56; no new reading-position lint error

Covered scenarios

  1. Reopening the same long document restores its saved normalized position.
  2. Cached Recent entries reuse the source document position.
  3. Short/non-scrollable documents clamp safely to the top.
  4. Deferred content growth preserves the target progress until the reader interacts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant