expansion: add test for default language - #706
Open
BigBlueHat wants to merge 3 commits into
Open
BigBlueHat wants to merge 3 commits into
BigBlueHat wants to merge 3 commits into
Conversation
This adds a test to check that when the context has a default language and we're expanding a string value that has a type mapping, the default language is not added. It ensures Step 5 in Value Expansion is only performed for string values in the absence of a type mapping. Fixes: #700
anatoly-scherbakov
approved these changes
Aug 12, 2026
niklasl
approved these changes
Sep 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@daenney GitHub accidently closed #702, so this is it again but on
mainwhich no longer has the fork bug.Thanks for the help!