Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 made
tightbeam-derivea required dependency, so thederivefeature enabled nothing yet still gated code, and derived error and wire types kept hand-written fallbacks that only narrow builds compiled. Removing the feature leaves one implementation per type, andBeamablenow checks tightbeam's own features instead of a copy in the derive crate.Related Issues
None
Changes Made
derivefeature no longer exists#[error]declaration in every buildBeamablefeature checks follow tightbeam's features directlyserver!service error names thepooled_muxaliasTesting
make test-all: passes#[beam(confidential)]withoutaeadfails with the feature messageBreaking Changes
"derive"fromtightbeam-rsfeature lists. The derives are always available.tightbeam-derivedrops itsaead,digest,signature, andcompressfeatures. Remove any direct enable.Note
Medium Risk
Breaking change for downstream
features = ["derive"]and tightbeam-derive feature flags; behavior is mostly compile-time/API surface with no auth or wire-format changes.Overview
Removes the
deriveCargo feature now thattightbeam-deriveis always linked:Beamable,Flaggable, andErrorizableare unconditional, and the large#[cfg(not(feature = "derive"))]manualMessage, errorDisplay, and URN-spec fallbacks are deleted.Beamablefeature validation no longer usescfg!(feature = …)insidetightbeam-derive(or mirrored derive-crate features). It emits__tb_if_aead/__tb_if_signature/__tb_if_digest/__tb_if_compresswith anelse { compile_error!(…) }branch so missingaead,signature,digest, orcompresson tightbeam-rs fails at compile time with a clear message.Feature wiring cleanup:
builder,colony,instrument, andcompressdropderive/tightbeam-derive/*deps; consumer crates andtest_features.shstop enabling"derive". Theserver!pooled-muxcompile_errortext now points at thepooled_muxbuild alias.Reviewed by Cursor Bugbot for commit 4e3cbb0. Bugbot is set up for automated code reviews on this repo. Configure here.