Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes typed certificate fingerprints and SKIDs, forces low-s on every verify path that already holds a prehash, and puts mux accept/authorize on one negotiation carrier. Callers can no longer skip SID checks or mint fingerprints from raw digests.
Related Issues
None
Changes Made
Fingerprint::from_certificateTransportNegotiationvalidate_expiry_atCryptoPolicyError,apply_domain, andSecretFixedTagTesting
make test-all: passesBreaking Changes
Fingerprint/Skidare newtypes. Replace[u8; 32]/[u8; 20]aliases&'static [u8; 32]. Runtime pins takeFingerprint<D>CryptoPolicyErrorandapply_domainare gone. Map rejects toCertificateValidationErrorSigningProvider/Frame::verifymust implementLowSEncodingNote
High Risk
Touches authentication-critical paths (signature verification, certificate trust/pinning, handshake receipts, and peer identity) with breaking API changes; incorrect migration could weaken identity binding or accept malleable signatures.
Overview
Introduces typed
Fingerprint<D>andSkidfor certificate identity, routes trust/pinning/revocation and cluster peer keys throughFingerprint::from_certificateandCertificateTrustStore::to_fingerprint::<Sha3_256>, and centralizes SKID parsing inSkid::parse.Adds
LowSEncodingand threads it throughverify_canonical,SigningProvider, frame verify, CMS/ECIES handshake, and session receipts so high-s ECDSA encodings are rejected consistently.EcdsaSignatureVerifiernow always requires a matchingSignerIdentifier, and signer IDs are built via sharedcompute_signer_identifier.Handshake mux negotiation moves onto
TransportNegotiation(accept/authorize), replacing the old free functions. Certificate expiry checks sharevalidate_expiry_at. Cleanup removesCryptoPolicyError,apply_domain, andSecret’sFixedTag; X9.63 KDF expansion is deduplicated inX963Sha3_256::expand.Reviewed by Cursor Bugbot for commit 63decea. Bugbot is set up for automated code reviews on this repo. Configure here.