feat: proto-defined client interface - #24
Merged
Merged
Conversation
- define RfmsApi service with 3 RPCs (Vehicles, VehiclePositions, VehicleStatuses) - add protoc-gen-connect-go to buf.gen.yaml (simple mode) - implement RfmsApiClient interface assertion in client.go - migrate all method signatures from Go value types to proto req/resp pointers - update CLI commands to use proto request builders - upgrade to Go 1.26, add .golangci.yml with golines/gci/gofumpt formatters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RfmsApiproto service with 3 RPCs covering the rFMS APIprotoc-gen-connect-goplugin withsimplemode*Clientnow implementsrfmsv5connect.RfmsApiClient(compile-time assertion)opts ...ClientOptionper-request overrides, removeclientConfig.with().golangci.yml, GOFLAGS=-mod=mod for linterTest plan
./tools/mage Lint— 0 issues./tools/mage Test— all tests passgo build ./...— compiles cleanly