refactor: use connect error codes instead of custom Error type - #27
Merged
Merged
Conversation
- Wrap Error in connect.NewError() via connectError() method (preserves errors.As for rate-limit info) - Add HTTP-level client_test.go with httptest.NewServer coverage - Tests verify all 3 methods, error code mapping, and rate-limit header preservation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Errorinconnect.NewError()viaconnectError()method (preserveserrors.Asfor rate-limit info)client_test.gowithhttptest.NewServercoverageMotivation
Aligns with SDK conformance standard: consumers get standard Connect error codes while retaining access to rich error details (rate-limit reset duration) via
errors.As.Test plan
go build ./...passesgo test ./...passeserrors.As(err, &rfms.Error{})still works through connect wrapperRetry-Afterheader preserved in unwrapped error