chore(build): enable Rspack runtime mode - #1927
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes have been assessed with no unresolved blocking issues.
Pull request overview
Enables Rspack runtime mode for the three published packages.
Changes:
- Configures
runtimeMode: 'rspack'for core, plugin-dts, and create-rslib. - Preserves existing package-specific settings.
File summaries
| File | Description |
|---|---|
packages/plugin-dts/rslib.config.ts |
Enables Rspack runtime mode. |
packages/create-rslib/rslib.config.ts |
Enables Rspack runtime mode. |
packages/core/rslib.config.ts |
Enables Rspack runtime mode. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enable Rspack's experimental runtime output for the three packages published from this repository. This reduces the internal runtime overhead and aligns the ESM bundle output with Rspack's named runtime bindings.
Changes
Configure
tools.rspack.experiments.runtimeModeas"rspack"for@rslib/core,rsbuild-plugin-dts, andcreate-rslib. The generated runtime now uses named ESM exports such asrspackRequireandmoduleFactories;create-rslibhas no standalone runtime chunk and is unchanged.Validation:
pnpm lintpassed.node --checkand public ESM import smoke tests.The option remains experimental in Rspack, so future Rspack minor releases may change its runtime output.