test: update CJS external rendering assertions - #1929
Merged
Merged
Conversation
Timeless0911
force-pushed
the
david/fix-update-cjs-rendering-tests
branch
4 times, most recently
from
September 18, 2026 09:31
1be3dea to
ce95a05
Compare
Timeless0911
force-pushed
the
david/fix-update-cjs-rendering-tests
branch
from
September 18, 2026 09:37
ce95a05 to
87ffa11
Compare
Timeless0911
marked this pull request as ready for review
September 18, 2026 09:38
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Updates externals integration assertions for Rspack’s direct CommonJS rendering in modern-module output.
Changes:
- Update Node and web assertions for direct
require/createRequirecalls. - Preserve checks for bundled wrappers and lazy imports.
File summaries
| File | Summary |
|---|---|
tests/integration/externals/index.test.ts |
Updates external-rendering expectations. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rspack #15238 changed how eligible CommonJS externals are rendered in
modern-moduleoutput. The existing Rslib integration assertions expected the previousmodule.exportsfactory output, causing the Rspack ecosystem CI externals suite to fail.Related: web-infra-dev/rspack#15238
Changes
Update the externals integration assertions for the new direct CJS rendering in Node and web targets, while preserving checks for
require,createRequire, bundled CommonJS wrappers, and lazy imports.Validation: built Rspack commit
475c7ad20flocally and rantests/integration/externals/index.test.tswith 10/10 tests passing. Lint and format checks also pass.Closes #1931