Skip to content

fix(runtime): avoid dead require bootstrap - #14991

Merged
LingyuCoder merged 2 commits into
mainfrom
seal/remove-dead-require-bootstrap
Jul 30, 2026
Merged

LingyuCoder merged 2 commits into
mainfrom
seal/remove-dead-require-bootstrap

Conversation

@LingyuCoder

Copy link
Copy Markdown
Contributor

Summary

  • avoid emitting the Rspack require bootstrap when module is used but no module factory table exists
  • remove the resulting dead module cache and undeclared module-table reference from Rslib-style static CommonJS output
  • add regression coverage for asset output using runtimeMode: "rspack"

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Validation

  • cargo fmt --all --check
  • local development binding build
  • rstest --project base -t 'rslib/no-dead-require-bootstrap' Config.part3.test.js RuntimeModeConfig.part3.test.js
  • rstest --project base -t 'runtime/runtime-mode' RuntimeModeConfig.part1.test.js RuntimeModeConfig.part2.test.js RuntimeModeConfig.part3.test.js

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 27a46a5 to chore: migrate Git hooks to Rstack CLI (#14989) by Jiahan Chen

🙈 Size remains the same at 66.74MB

@LingyuCoder
LingyuCoder marked this pull request as ready for review July 29, 2026 14:00
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 552.1 KB 0 0
react-10k 5.6 MB 1.3 MB 0 0
react-1k 823.1 KB 217.0 KB 0 0
ui-components 4.9 MB 1.4 MB 0 0
react-5k 2.7 MB 663.8 KB 0 0

Generated by Rsdoctor GitHub Action

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b39a46e6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/rspack_plugin_javascript/src/plugin/runtime_context.rs Outdated
@codspeed

codspeed Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing seal/remove-dead-require-bootstrap (27a46a5) with main (d7c037a)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@LingyuCoder
LingyuCoder enabled auto-merge (squash) July 30, 2026 03:18
@LingyuCoder
LingyuCoder requested a review from JSerFeng July 30, 2026 03:18
@LingyuCoder
LingyuCoder merged commit f02db46 into main Jul 30, 2026
39 checks passed
@LingyuCoder
LingyuCoder deleted the seal/remove-dead-require-bootstrap branch July 30, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants